Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix index meta mutex contention #38775

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

issue: #37630

Reduce the frequency of updateIndexTasksMetrics to avoid holding the mutex for long periods.

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 26, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Dec 26, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 26, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

czs007 pushed a commit that referenced this pull request Dec 26, 2024
issue: #37630

Reduce the frequency of updateIndexTasksMetrics to avoid holding the
mutex for long periods.

pr: #38775

---------

Signed-off-by: bigsheeper <[email protected]>
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.10%. Comparing base (94955e5) to head (55e83b4).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38775      +/-   ##
==========================================
- Coverage   82.90%   81.10%   -1.81%     
==========================================
  Files        1089     1383     +294     
  Lines      169219   195625   +26406     
==========================================
+ Hits       140296   158653   +18357     
- Misses      23332    31381    +8049     
  Partials     5591     5591              
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.43% <ø> (∅)
Go 83.09% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/index_meta.go 96.73% <100.00%> (+1.41%) ⬆️

... and 320 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants