Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Fix index meta mutex contention #38778

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

issue: #37630

Reduce the frequency of updateIndexTasksMetrics to avoid holding the mutex for long periods.

pr: #38775

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (147c6b0) to head (9555ca9).
Report is 2 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.5   #38778   +/-   ##
=======================================
  Coverage   81.05%   81.06%           
=======================================
  Files        1381     1381           
  Lines      195185   195178    -7     
=======================================
+ Hits       158207   158214    +7     
+ Misses      31411    31394   -17     
- Partials     5567     5570    +3     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.34% <ø> (ø)
Go 83.04% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/index_meta.go 96.37% <100.00%> (+1.04%) ⬆️

... and 29 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants