Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Fix index meta mutex contention #38776

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

issue: #37630

Reduce the frequency of updateIndexTasksMetrics to avoid holding the mutex for long periods.

pr: #38775

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 26, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign liliu-z after the PR has been reviewed.
You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.39%. Comparing base (92c7f6a) to head (4eff4db).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38776      +/-   ##
==========================================
+ Coverage   80.37%   83.39%   +3.01%     
==========================================
  Files        1077      809     -268     
  Lines      169559   143057   -26502     
==========================================
- Hits       136291   119303   -16988     
+ Misses      28781    19277    -9504     
+ Partials     4487     4477      -10     
Files with missing lines Coverage Δ
internal/datacoord/index_meta.go 97.20% <100.00%> (+1.63%) ⬆️

... and 293 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants