Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bandlab] add extractor (supersedes #31206) (Closes #31184) #32881

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aiur-adept
Copy link
Contributor

@aiur-adept aiur-adept commented Jul 25, 2024

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Bandlab extractor for individual posts, albums, and collections

Closes #31184

@aiur-adept
Copy link
Contributor Author

This is a continuation of #31206

@dirkf dirkf changed the title bandlab extractor [bandlab] add extractor (supersedes #31206) Jul 25, 2024
@aiur-adept aiur-adept mentioned this pull request Jul 28, 2024
5 tasks
@aiur-adept aiur-adept changed the title [bandlab] add extractor (supersedes #31206) [bandlab] add extractor (supersedes #31206) (Closes #31184) Jul 28, 2024
@aiur-adept
Copy link
Contributor Author

@dirkf I think this can merge now

@dirkf
Copy link
Contributor

dirkf commented Sep 11, 2024

You can put (eg) Supersedes, closes #31206 in the PR description to have that PR closed automatically when this is merged.

@dirkf dirkf mentioned this pull request Nov 13, 2024
11 tasks
@seproDev
Copy link

Consider taking a look at yt-dlp/yt-dlp#11535
It's for yt-dlp (a fork of youtube-dl), so no Python 2.6 compat, and I am not sure if all the helpers introduced in yt-dlp have made their way to youtube-dl, but it should be a solid reference point for improving this extractor.
I spend a fair bit of time making sure the extractor works with all kinds of links (tracks, revisions, videos, posts, embeds, unlisted tracks, private tracks). The extractor in yt-dlp also extracts more metadata than this current PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BandLab
3 participants