[bandlabextractor] added new bandlab extractor for track, album, and playlist…

[dt-rush]

Before submitting a pull request make sure you have:

• Searched the bugtracker for similar pull requests
• Read adding new extractor tutorial
• Read youtube-dl coding conventions and adjusted the code to meet them
• Covered the code with tests (note that PRs without tests will be REJECTED)
• Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

• I am the original author of this code and I am willing to release it under Unlicense
• I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

• Bug fix
• Improvement
• New extractor
• New feature

---

Description of your pull request and other information

Added a bandlab extractor. Resolves #31184

[dt-rush]

@dirkf the first run of the tests failed on one specific test because there was a utf8 string. I changed the test for the extractor to use a song which doesn't have utf8 chars in the name. All tests should pass if run again.

[dirkf]

You should be able to put back the Unicode test data now.

[dt-rush]

@dirkf no worries. It doesn't really make the test any more robust. It just happened i chose a song with a unicode title. Should be clear to merge from my side :)

[itzTheMeow]

is there a status on this? seems good to go

[dt-rush]

Yep it can be merged any time.

[dirkf]

Thanks for your work!

I've what may seem to be a lot of suggestions, but basically they come down to two things:

1. in new extractors, _TESTS is preferred to _TEST;
2. unifying the extraction code for the album and playlist extractors, which are almost identical.

In the second (7-part) change, you could also change the order of the two classes so that the derived IE is later.

[itzTheMeow]

@dt-rush any status on this?

[dt-rush]

Hey @dirkf ! Thanks for the suggestions! I just updated the branch. Changes:

• The playlist and album extractors are merged into a single class since the logic is virtually identical except for using the string "albums" or "collections" in one or the other.

• _TEST is _TESTS

• we now use try_get() for the various metadata fields (I initially thought, the extractor should break if the format changes, but after reading the README a little more, I see the logic)

Cheers!

[itzTheMeow]

nice nice! eager to see this merged

[dirkf]

Let's check the CI tests after I fix (I hope) the Flake8 issues.

There are still some unresolved points from the previous review, plus the new ones here.

[dt-rush]

@dirkf fixed!

[orithecapper]

bump

[aiur-adept]

Hey all, this should be clear to merge. This is my new account (I'm @dt-rush). @dirkf, can you merge this please? Thank you! :)

[dirkf]

Suggested change

	resource_id = self._match_id(url)
	kind_regex = re.compile(self._VALID_URL)
	kind = kind_regex.match(url).group('kind')
	resource_id, kind = self._match_valid_url(url).group('id', 'kind')

[dirkf]

Download tests fail with 403 on API request.

In the browser: {"errorCode":403,"message":"Current user does not have permission for this action."}

Changes made

[itzTheMeow]

@aiur-adept the tracks i provided in the original example (and the ones being used for the tests) have since been privated/removed so they should probably be changed to existing tracks/albums

that'd probably be the reason for the 403

[aiur-adept]

@itzTheMeow @dirkf it seems the helper methods from utils.py no longer exist. Were they moved somewhere else?

[aiur-adept]

(for example, traverse_obj)

[dirkf]

In this PR it might be necessary to pull the latest yt-dl source.

In case anyone is trying to use the extractor with yt-dlp, they moved traverse_obj() and friends to utils/traversal.py. We have a traversal.py that just redirects the imports to utils.py.

[aiur-adept]

@dirkf thanks, i'm gonna rebase on upstream master and try to get this working

[aiur-adept]

#32881 has been pushed with fixed test data. This PR can close now in preference of that one.