Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BandLab #31184

Open
5 tasks done
itzTheMeow opened this issue Aug 19, 2022 · 10 comments · May be fixed by #31206 or #32881
Open
5 tasks done

BandLab #31184

itzTheMeow opened this issue Aug 19, 2022 · 10 comments · May be fixed by #31206 or #32881
Assignees
@dt-rush
Labels
Good first issue An issue that should be easier to solve site-support-request Add extractor(s) for a new domain

Comments

@itzTheMeow
Copy link

itzTheMeow commented Aug 19, 2022 •
edited
Loading

Checklist

  • I'm reporting a new site support request
  • I've verified that I'm running youtube-dl version 2021.12.17
  • I've checked that all provided URLs are alive and playable in a browser
  • I've checked that none of provided URLs violate any copyrights
  • I've searched the bugtracker for similar site support requests including closed ones

Example URLs

Description

Support for downloading bandlab songs/playlists/albums.
@itzTheMeow itzTheMeow added the site-support-request Add extractor(s) for a new domain label Aug 19, 2022
@dirkf
Copy link
Contributor

dirkf commented Aug 19, 2022

The site is a JS application with no meaningful data in the pages that yt-dl would see. An implementer will have to analyze the web traffic generated by the application to see if a yt-dl extractor can support the necessary subset of the interactions.

@dirkf
Copy link
Contributor

dirkf commented Aug 19, 2022

Indeed, you've done the analysis that I mentioned and contrary to expectation this is rather straightforward.

In case someone wants to do the rest of the job:

linked JSON, pretty-printed 

{
  'caption': 'unreleased song. might use later',
  'comments': [
    {
      'content': 'absolutely insane',
      'counters': {
        'likes': 0,
        'replies': 0
      },
      'createdOn': '2022-08-18T01:39:35Z',
      'creator': {
        'id': '1ee1b5a5-122c-4c05-94e4-ec6dc48001a5',
        'isTippable': false,
        'isVerified': false,
        'name': 'Meow',
        'picture': {
          'blur': {
            'xs': 'https://bandlabimages.azureedge.net/v1.0/users/default/100x100/blur',
            's': 'https://bandlabimages.azureedge.net/v1.0/users/default/360x360/blur',
            'm': 'https://bandlabimages.azureedge.net/v1.0/users/default/640x640/blur',
            'l': 'https://bandlabimages.azureedge.net/v1.0/users/default/1024x1024/blur'
          },
          'color': null,
          'isDefault': true,
          'l': 'https://bandlabimages.azureedge.net/v1.0/users/default/1024x1024',
          'm': 'https://bandlabimages.azureedge.net/v1.0/users/default/640x640',
          'original': 'https://bandlabimages.azureedge.net/v1.0/users/default/',
          's': 'https://bandlabimages.azureedge.net/v1.0/users/default/360x360',
          'url': 'https://bandlabimages.azureedge.net/v1.0/users/default/',
          'xs': 'https://bandlabimages.azureedge.net/v1.0/users/default/100x100'
        },
        'username': 'alexmeow4560'
      },
      'id': '38684107',
      'isLiked': false,
      'permissions': {
        'delete': false
      }
    },
    {
      'content': 'i love',
      'counters': {
        'likes': 0,
        'replies': 0
      },
      'createdOn': '2022-08-17T13:51:20Z',
      'creator': {
        'id': '64c599f5-4055-44f2-875e-5c2da3e84ea8',
        'isTippable': false,
        'isVerified': false,
        'name': 'velo',
        'picture': {
          'blur': {
            'xs': 'https://bandlabimages.azureedge.net/v1.0/users/b23b9db6-6d1b-4a52-8316-05fe1104164b/100x100/blur',
            's': 'https://bandlabimages.azureedge.net/v1.0/users/b23b9db6-6d1b-4a52-8316-05fe1104164b/360x360/blur',
            'm': 'https://bandlabimages.azureedge.net/v1.0/users/b23b9db6-6d1b-4a52-8316-05fe1104164b/640x640/blur',
            'l': 'https://bandlabimages.azureedge.net/v1.0/users/b23b9db6-6d1b-4a52-8316-05fe1104164b/1024x1024/blur'
          },
          'color': '#4A3B5E',
          'isDefault': false,
          'l': 'https://bandlabimages.azureedge.net/v1.0/users/b23b9db6-6d1b-4a52-8316-05fe1104164b/1024x1024',
          'm': 'https://bandlabimages.azureedge.net/v1.0/users/b23b9db6-6d1b-4a52-8316-05fe1104164b/640x640',
          'original': 'https://bandlabimages.azureedge.net/v1.0/users/b23b9db6-6d1b-4a52-8316-05fe1104164b/',
          's': 'https://bandlabimages.azureedge.net/v1.0/users/b23b9db6-6d1b-4a52-8316-05fe1104164b/360x360',
          'url': 'https://bandlabimages.azureedge.net/v1.0/users/b23b9db6-6d1b-4a52-8316-05fe1104164b/',
          'xs': 'https://bandlabimages.azureedge.net/v1.0/users/b23b9db6-6d1b-4a52-8316-05fe1104164b/100x100'
        },
        'username': 'velo488'
      },
      'id': '38660956',
      'isLiked': false,
      'permissions': {
        'delete': false
      }
    }
  ],
  'counters': {
    'comments': 2,
    'likes': 5,
    'plays': 11
  },
  'createdOn': '2022-05-23T01:54:42Z',
  'creator': {
    'id': 'f5f04998-635a-44ea-819c-acdba7ae2076',
    'isTippable': false,
    'isVerified': false,
    'name': 'Michael MacDonald',
    'picture': {
      'blur': {
        'xs': 'https://bandlabimages.azureedge.net/v1.0/users/e5623735-1f57-4ef5-a7c0-91802a7ef233/100x100/blur',
        's': 'https://bandlabimages.azureedge.net/v1.0/users/e5623735-1f57-4ef5-a7c0-91802a7ef233/360x360/blur',
        'm': 'https://bandlabimages.azureedge.net/v1.0/users/e5623735-1f57-4ef5-a7c0-91802a7ef233/640x640/blur',
        'l': 'https://bandlabimages.azureedge.net/v1.0/users/e5623735-1f57-4ef5-a7c0-91802a7ef233/1024x1024/blur'
      },
      'color': '#3C4A55',
      'isDefault': false,
      'l': 'https://bandlabimages.azureedge.net/v1.0/users/e5623735-1f57-4ef5-a7c0-91802a7ef233/1024x1024',
      'm': 'https://bandlabimages.azureedge.net/v1.0/users/e5623735-1f57-4ef5-a7c0-91802a7ef233/640x640',
      'original': 'https://bandlabimages.azureedge.net/v1.0/users/e5623735-1f57-4ef5-a7c0-91802a7ef233/',
      's': 'https://bandlabimages.azureedge.net/v1.0/users/e5623735-1f57-4ef5-a7c0-91802a7ef233/360x360',
      'url': 'https://bandlabimages.azureedge.net/v1.0/users/e5623735-1f57-4ef5-a7c0-91802a7ef233/',
      'xs': 'https://bandlabimages.azureedge.net/v1.0/users/e5623735-1f57-4ef5-a7c0-91802a7ef233/100x100'
    },
    'username': 'sbsdasani'
  },
  'id': 'f5f04998635a44ea819cacdba7ae2076_f8d8574c3bdaec11b6562818783151a1',
  'isCommentingAllowed': true,
  'isExplicit': false,
  'isLiked': false,
  'permissions': {
    'comment': false,
    'delete': false,
    'edit': false
  },
  'revisionId': 'f7d8574c-3bda-ec11-b656-2818783151a1',
  'state': 'Public',
  'track': {
    'genreId': 'other',
    'isHiRes': false,
    'name': 'ON MY OWN (unreleased)',
    'permissions': {
      'download': true
    },
    'picture': {
      'blur': {
        'xs': 'https://bl-prod-images.azureedge.net/v1.3/tracks/1d2a78d9-f8e9-4928-9e73-46f010dbe360/100x100/blur',
        's': 'https://bl-prod-images.azureedge.net/v1.3/tracks/1d2a78d9-f8e9-4928-9e73-46f010dbe360/360x360/blur',
        'm': 'https://bl-prod-images.azureedge.net/v1.3/tracks/1d2a78d9-f8e9-4928-9e73-46f010dbe360/640x640/blur',
        'l': 'https://bl-prod-images.azureedge.net/v1.3/tracks/1d2a78d9-f8e9-4928-9e73-46f010dbe360/1024x1024/blur'
      },
      'color': '#595F6C',
      'isDefault': false,
      'l': 'https://bl-prod-images.azureedge.net/v1.3/tracks/1d2a78d9-f8e9-4928-9e73-46f010dbe360/1024x1024',
      'm': 'https://bl-prod-images.azureedge.net/v1.3/tracks/1d2a78d9-f8e9-4928-9e73-46f010dbe360/640x640',
      'original': 'https://bl-prod-images.azureedge.net/v1.3/tracks/1d2a78d9-f8e9-4928-9e73-46f010dbe360/',
      's': 'https://bl-prod-images.azureedge.net/v1.3/tracks/1d2a78d9-f8e9-4928-9e73-46f010dbe360/360x360',
      'url': 'https://bl-prod-images.azureedge.net/v1.3/tracks/1d2a78d9-f8e9-4928-9e73-46f010dbe360/',
      'xs': 'https://bl-prod-images.azureedge.net/v1.3/tracks/1d2a78d9-f8e9-4928-9e73-46f010dbe360/100x100'
    },
    'sample': {
      'audioFormat': 'm4a',
      'audioUrl': 'https://static.bandlab.com/revisions-formatted/6d1e0232-d7b4-4476-8c7a-e67900fbd8b0/6d1e0232-d7b4-4476-8c7a-e67900fbd8b0.m4a',
      'duration': 211.63,
      'status': 'Ready',
      'uploadUrl': null,
      'waveformUrl': 'https://static.bandlab.com/revisions-formatted/6d1e0232-d7b4-4476-8c7a-e67900fbd8b0/6d1e0232-d7b4-4476-8c7a-e67900fbd8b0.json'
    }
  },
  'type': 'Track'
}

The other page types work the same way:
https://www.bandlab.com/api/v1.3/albums/dc26e307-e51f-ed11-95d7-002248452390
https://www.bandlab.com/api/v1.3/collections/20356f3f-8d3f-e811-80c3-00155d65202b

@dirkf dirkf added the Good first issue An issue that should be easier to solve label Aug 19, 2022
@danyalasif
Copy link

Hey dirkf, I'd like to give this a shot. Please assign it to me if it's still available. I'm setting up the project right now.

@dirkf
Copy link
Contributor

dirkf commented Aug 23, 2022

Good luck!

@dt-rush dt-rush linked a pull request Aug 28, 2022 that will close this issue
Open
11 tasks
@dt-rush
Copy link

dt-rush commented Aug 28, 2022

Sorry @dirkf I had this tab open for days and didn't refresh to see you claimed it. I just finished the work and posted the PR here:

#31206

@danyalasif
Copy link

@dt-rush Ah, it's okay. I just started working on it today on the weekend. You can take it then. :)

@dt-rush
Copy link

dt-rush commented Aug 28, 2022

@danyalasif aaaand I tagged the wrong person to begin with lol. Cheers m8 :)

@dirkf dirkf assigned dt-rush and unassigned danyalasif Aug 29, 2022
@aiur-adept
Copy link
Contributor

Bandlab support has been implemented in #32881

@dirkf
Copy link
Contributor

dirkf commented Jul 28, 2024

Please put the magic string Closes #31184 in the Description of your PR #32881.

@aiur-adept aiur-adept linked a pull request Jul 28, 2024 that will close this issue
Open
11 tasks
@aiur-adept
Copy link
Contributor

@dirkf done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dt-rush dt-rush

Labels
Good first issue An issue that should be easier to solve site-support-request Add extractor(s) for a new domain
Projects
None yet
Milestone
No milestone
5 participants
@dirkf @danyalasif @dt-rush @itzTheMeow @aiur-adept