[DebugInfo] Fix debug info round tripping of types inside functions #78328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@augusto2112 It seems like I still locally get a crash with this PR. I will double-check. |
|
@swift-ci test |
augusto2112
force-pushed
the
fix-orig-def-type-in-func
branch
from
a3bad1a to
3bb29ca
Compare
|
@swift-ci test |
|
@hjyamauchi thanks for testing, could you try again with the latest commit? |
compnerd
approved these changes
Dec 20, 2024
Types with @_originallyDefinedIn cannot be round tripped, Types declared inside functions have their mangling affected by the function signature. If the generic signature mentions an @_originallyDefinedIn type, the type inside the function cannot be round tripped either. This commit disables round tripping for this scenario.
augusto2112
force-pushed
the
fix-orig-def-type-in-func
branch
from
3bb29ca to
d75bde3
Compare
|
@swift-ci smoke test |
@augusto2112 Will do. I also added a reduced test here: #78326 (comment) |
@augusto2112 The updated PR doesn't seem to fix the issue for me. |
|
That's surprising, let me check again if I'm missing some other case... |
|
@augusto2112 It might be useful to use the reduced test from here: #78326 (comment) |
|
@hjyamauchi thanks, I was able to use your reproducer. It actually was not related to @_originallyDefinedIn as I thought, but something else entirely. I'm running the test suite locally and hopefully this will be the last iteration of the fix. |
augusto2112
requested review from
hborla,
slavapestov and
xedin
as code owners
Now that mangling for the debugger respects originally defined in, this is not needed anymore.
augusto2112
force-pushed
the
fix-orig-def-type-in-func
branch
from
f1d3bc8 to
398ded5
Compare
|
@swift-ci test |
|
@hjyamauchi if you're around this should work with your test case now :) |
|
@swift-ci smoke test |
Testing |
|
It looks good! |
hjyamauchi
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types with @_originallyDefinedIn cannot be round tripped,
Types declared inside functions have their mangling affected by the function signature. If the generic signature mentions an @_originallyDefinedIn type, the type inside the function cannot be round tripped either.
This commit disables round tripping for this scenario.