-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[DebugInfo] Fix handling of @_originallyDefinedIn types" #78324
base: main
Are you sure you want to change the base?
Conversation
@swift-ci please smoke test |
@compnerd do you know which type is triggering the assertion failure? |
There's no way to do the round trip when the type is annotated with @_originallyDefinedIn. I added some code to skip the round tripping for types affected by that attribute, but maybe I missed some cases. |
|
What project are you compiling? I don't see any |
Reverting this PR seems to fix this issue: #78326 CC @augusto2112 |
I was able to reproduce it, let me work on a fix |
@augusto2112 can we revert the change if you cannot get the fix in before the freeze tonight? |
@compnerd in case mine fails in some other unexpected way you can open a PR reverting ce1a9d565f537f81b3d40e67666c91e9cc178938 and 15bb8ecccd8b371b9b33a876d8b04e8f8aa42eea on llvm-project, and cross testing with this one, to get it ready to merge just in case. |
Please test with following PRs: @swift-ci please smoke test |
Reverts #78104
This is potentially breaking the round trip of symbol decoration.