Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new event list widget #2623

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

buletti
Copy link
Contributor

@buletti buletti commented Jan 7, 2022

This PR introduces a new widget for the dashboard. The purpose of the new widget is to display a list of events of various types for a given time period. The events list is sorted in chronological order. Depending on the given reporting period the displayed events can be past events, current events or upcoming events.

The widget currently supports the following different types of events:

  • Calendar events
    • Holidays
  • Account events
    • Interest payment/booking
  • Security events
    • Dividend declaration(*)
    • Dividend record date(*)
    • Ex-dividend date(*)
    • Dividend payday(*)
    • Dividend payment/booking
    • Shareholder meeting(*)
    • Earnings report(*)
    • Stock split
    • Note/custom event

Changes:

  • added the new event list widget
  • extended the existing security event types of the model; new types marked by (*) above
  • adjusted the UI to also create events for the new security event types
    • adjusted context menus
    • adjusted event creation wizard pages

Limitations:

  • translation is quick and dirty; created with google translate
  • for the event type markers I reused already existing icons. I think they are working ok, but using specifically designed icons would of course be nicer

Screenshots:

A demo dashboard with event list widgets of various reporting periods:
pp_event_list_widget

The adjusted context menu in the statement of assets listing:
pp_events_context_menu_soa

The adjusted context menu in the statement of assets pane:
pp_events_context_menu_soa_pane

An example creation dialog page for an earnings report event:
pp_earnings_report_event_dialog

The unchanged creation dialog page for a custom event with a free-form text input field:
pp_custom_event_dialog

Attachments:

this commit replaces the existing "custom event" context menu entry with
a new, more generic "events" context menu entry. The new "events"
context menu entry can be expanded and then used to spawn creation
dialogs for specific event type instances.
@buchen
Copy link
Member

buchen commented Jan 9, 2022

I like the idea. I need more time to review (the update to the protobuf serialization is definitely missing). Today, I am looking only at the "easy/small" changes to put together a release

@buletti
Copy link
Contributor Author

buletti commented Jan 9, 2022

Thanks Andreas.
Protobuf support added

@buletti
Copy link
Contributor Author

buletti commented Mar 30, 2022

Is there any way I can help to move this along?

@heldic
Copy link

heldic commented Jun 15, 2022

This looks awesome! Thought I'd add a comment to bump this & deliver a big Kudos to you @buletti !

@cla-azzarello
Copy link

Please take a look on #3099

@pfalcon
Copy link
Contributor

pfalcon commented May 27, 2023

@buletti :

Is there any way I can help to move this along?

Perhaps you could rebase this on master from time to time, to keep in more "ready" state? Currently Github says "This branch has conflicts that must be resolved".

@pfalcon
Copy link
Contributor

pfalcon commented Dec 30, 2024

I had a look at this patch and found following issues with it:

  • Even the base commit, "introduce event list widget", looks a bit over-engineered. It tries to pack too many things into the initial version, and the way it's implemented, it doesn't scale to larger portfolio files (like, taking a couple of minutes to render).
  • But it doesn't stop there. It goes further by adding new event types, etc. We absolutely need more event types. But adding them has nothing to do with "introducing of event list widget".

IMHO, what we need is a simple, barebones security event list widget reusing as much as possible of the current widget infrastructure (and by that I mean subclassing from AbstractSecurityListWidget). It may be not much useful, but it's still huge step from no event widget at all, and being simple, hopefully will allow @buchen to merge it fast(er). Then we can build on it, adding more features step by step. With that in mind, I posted #4431 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants