-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new event list widget #2623
base: master
Are you sure you want to change the base?
Conversation
dates in the future
this commit replaces the existing "custom event" context menu entry with a new, more generic "events" context menu entry. The new "events" context menu entry can be expanded and then used to spawn creation dialogs for specific event type instances.
I like the idea. I need more time to review (the update to the protobuf serialization is definitely missing). Today, I am looking only at the "easy/small" changes to put together a release |
Thanks Andreas. |
Is there any way I can help to move this along? |
This looks awesome! Thought I'd add a comment to bump this & deliver a big Kudos to you @buletti ! |
Please take a look on #3099 |
@buletti :
Perhaps you could rebase this on master from time to time, to keep in more "ready" state? Currently Github says "This branch has conflicts that must be resolved". |
I had a look at this patch and found following issues with it:
IMHO, what we need is a simple, barebones security event list widget reusing as much as possible of the current widget infrastructure (and by that I mean subclassing from AbstractSecurityListWidget). It may be not much useful, but it's still huge step from no event widget at all, and being simple, hopefully will allow @buchen to merge it fast(er). Then we can build on it, adding more features step by step. With that in mind, I posted #4431 . |
This PR introduces a new widget for the dashboard. The purpose of the new widget is to display a list of events of various types for a given time period. The events list is sorted in chronological order. Depending on the given reporting period the displayed events can be past events, current events or upcoming events.
The widget currently supports the following different types of events:
Changes:
Limitations:
Screenshots:
A demo dashboard with event list widgets of various reporting periods:
The adjusted context menu in the statement of assets listing:
The adjusted context menu in the statement of assets pane:
An example creation dialog page for an earnings report event:
The unchanged creation dialog page for a custom event with a free-form text input field:
Attachments: