-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributed inference example for llava_next #3179
base: main
Are you sure you want to change the base?
Distributed inference example for llava_next #3179
Conversation
Hi @sayakpaul @a-r-r-o-w! This PR is ready for review, please, take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this so quickly. Left some comments.
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
91ee412
to
0a58faa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's some gap between the objectives. I thought we agreed on doing distributed captioning?
c9bb16e
to
b43581e
Compare
Hey @sayakpaul! Please, take a look on recent changes. Does it look ok to you? |
6e8fb0d
to
336def5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, I left some minor comments. I think this is close to merge.
Could you additionally show some sample outputs (i.e., video - generated caption pairs)?
@muellerzr I think this is now ready for your review. |
@sayakpaul Thank you for your review! Do you mean by providing some examples in description to the script? Just in case, as example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! As long as @sayakpaul is happy I'm happy 🤗
I did leave one suggestion/feedback, we need to destroy process groups now at the end else torch will get angry at us
Hey @sayakpaul! Do you have any additional comments or suggestions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Hi @muellerzr! I think this PR is ready to be merged or there is something else? |
Hi @muellerzr! Just a kind reminder in order to not lose this PR! |
Hi @sayakpaul @muellerzr! Just a kind reminder, I suppose this PR was missed to be merged. Please, take a look when you are available. |
Could I ask you to be a bit more respectful about pinging maintainers? You have pinged @muellerzr already once. So, that should be more than okay. |
Hi, sure, sry fo that, I just wanted to avoid moving this PR into stale or smth. |
Add distributed inference example for LLaVA-NeXT-Video-7B-hf
Before submitting
Pull Request section?
to it if that's the case. Link: [Community Contributions] examples on distributed inference using 🤗 Accelerate #3078
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul @a-r-r-o-w @muellerzr