[SPARK-50695][SQL] Alter table with properties check for empty string #49329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzifu666
changed the title
|
@yaooqinn PTAL if have free time, Thanks |
|
What's the problem you met with an empty string key? |
In platform indicate this would mistake for users, and this is not fitable for user to set empty key. @yaooqinn |
|
Due to this is a breaking change, mainly impact for indicate, so close it first. |
|
Thank you @xuzifu666 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Alter table with set properties check for key value
Why are the changes needed?
Currently sparksql not gurad for empty key properties such as '' = 'bb' which is not right
Does this PR introduce any user-facing change?
No
How was this patch tested?
DDLSuite: Test alter table command with empty key
Was this patch authored or co-authored using generative AI tooling?
No