[core] Alter table set option with empty key filter #4797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzifu666
changed the title
wwj6591812
reviewed
Dec 29, 2024
| List<SchemaChange> schemaChanges = new ArrayList<>(); | ||
| for (SchemaChange schemaChange : changes) { | ||
| if (schemaChange instanceof SchemaChange.SetOption | ||
| && StringUtils.isEmpty(((SchemaChange.SetOption) schemaChange).key())) { |
There was a problem hiding this comment.
What about throw a exception instead of continue?
There was a problem hiding this comment.
Thanks, empty is a non-sense config, maybe filter directly also OK, because if alter multiple config would not be terminated. @wwj6591812
|
Communicate with spark community，they suggest spark side also not do the change，this mainly impact in indicate for user， so close it first to keep the same with spark operation， related pr：apache/spark#49329 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Currently paimon set properties(options) not filter empty key:
ALTER TABLE T SET ('' = '2 mb');
then show create table :
CREATE TABLE
PAIMON.default.T(aINT,bINT,cINT) WITH (
'scan.infer-parallelism' = 'false',
'path' = '/var/folders/kb/wgkwnwq156g6kcpgldkyjcf00000gp/T/junit3546018753241373391/a5ced1b0-a37b-4879-b035-c14a351168d3/default.db/T',
'' = '2 mb'
'write-manifest-cache' = '1 mb'
)
this pr filter the empty option key
Tests
API and Format
Documentation