-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure: immich #368968
Comments
I can reproduce on the latest nixos-unstable. Looking into it |
This is a stop-gap, couldn't figure out how to get nodejs_22 working yet: diff --git a/pkgs/by-name/im/immich/package.nix b/pkgs/by-name/im/immich/package.nix
index 209cb2766612..b379400e8157 100644
--- a/pkgs/by-name/im/immich/package.nix
+++ b/pkgs/by-name/im/immich/package.nix
@@ -5,7 +5,7 @@
fetchFromGitHub,
fetchpatch2,
python3,
- nodejs,
+ nodejs_20,
node-gyp,
runCommand,
nixosTests,
@@ -27,6 +27,7 @@
vips,
}:
let
+ nodejs = nodejs_20;
buildNpmPackage' = buildNpmPackage.override { inherit nodejs; };
sources = lib.importJSON ./sources.json;
inherit (sources) version;
|
this is very strange - i would have expected this if |
@Titaniumtown Should I PR that fix for now so we can sort out the node 22 upgrade at our leisure? |
Steps To Reproduce
Steps to reproduce the behavior:
immich
Build log
Build Log
Additional context
The break was introduced to
master
fromstaging-next
in #361878 (fc9c333), which bumped the defaultnodejs
version from 20 to 22. Diffingnix derivation show
before (585f762) and after that merge shows no major differences aside from that change, and overriding thenodejs
version fixes the build. The following fails:but overriding to use nodejs_20 succeeds:
Note that upstream Immich updated from 20 to 22 immich-app/immich@a28b92b in
v1.120.0
, so while we could fix by pinning 20, we should probably figure out what will make 22 work.Metadata
"x86_64-linux"
Linux 6.6.66, NixOS, 24.11 (Vicuna), 24.11.20241221.dirty
no
yes
nix-env (Nix) 2.24.10
/nix/store/7lz01w5j2mw1nnshqmb6p47s38sia9pf-source
Notify maintainers
@dotlambda
@jvanbruegge
@Scrumplex
@Titaniumtown
Note for maintainers: Please tag this issue in your PR.
Add a 👍 reaction to issues you find important.
The text was updated successfully, but these errors were encountered: