Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

immich: use Node.js 20 #369042

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Conversation

Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Dec 29, 2024

Closes #368968

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Scrumplex and others added 2 commits December 29, 2024 10:01
Signed-off-by: Sefa Eyeoglu <[email protected]>
Co-authored-by: Simon Gardling <[email protected]>
Signed-off-by: Sefa Eyeoglu <[email protected]>
@ddogfoodd
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369042


x86_64-linux

✅ 2 packages built:
  • immich
  • immich-cli

@Scrumplex
Copy link
Member Author

I'd love to run the NixOS test, but triton-llvm currently fails to build. See #368790

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 labels Dec 29, 2024
@Scrumplex Scrumplex merged commit 17a08ed into NixOS:master Dec 29, 2024
47 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: immich
4 participants