Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

immich-public-proxy: init at 1.5.4, nixos/immich-public-proxy: init module #362907

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

Jaculabilis
Copy link
Contributor

immich-public-proxy is a proxy for sharing Immich albums without exposing the Immich API surface.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Dec 7, 2024
@Jaculabilis Jaculabilis changed the title immich-public-proxy: init at 1.5.3, init nixos module immich-public-proxy: init at 1.5.3, nixos/immich-public-proxy: init module Dec 7, 2024
@Jaculabilis
Copy link
Contributor Author

ping @jvanbruegge as immich maintainer

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 labels Dec 8, 2024
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Dec 8, 2024
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/immich-public-proxy.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/immich-public-proxy.nix Outdated Show resolved Hide resolved
pkgs/by-name/im/immich-public-proxy/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/im/immich-public-proxy/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/im/immich-public-proxy/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/im/immich-public-proxy/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/im/immich-public-proxy/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/im/immich-public-proxy/package.nix Outdated Show resolved Hide resolved
@dotlambda
Copy link
Member

We should give people the option to configure IPP as in https://github.com/alangrainger/immich-public-proxy/tree/main?tab=readme-ov-file#additional-configuration.

@Jaculabilis
Copy link
Contributor Author

We should give people the option to configure IPP as in https://github.com/alangrainger/immich-public-proxy/tree/main?tab=readme-ov-file#additional-configuration.

IPP's config path seems to be hardcoded as ../config.json. I'll see if upstream will take one more patch to allow setting that via IPP_CONFIG, then we can dump a freeform settings json and just pass that to the service envvar.

I'll push some changes to support a settings and include it in the module test in the next few days.

@Jaculabilis
Copy link
Contributor Author

@dotlambda Upstream is willing to cut a release with the upstreamed patches, so if the package and module look good (so we won't need any more patches), I can let upstream know to cut a 1.5.4 and then I can configure the package with an updateScript.

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 12, 2024
@Jaculabilis Jaculabilis changed the title immich-public-proxy: init at 1.5.3, nixos/immich-public-proxy: init module immich-public-proxy: init at 1.5.4, nixos/immich-public-proxy: init module Dec 23, 2024
@Jaculabilis
Copy link
Contributor Author

Hm, immich build seems to have been broken by #361878 (fc9c333). The module test passed on the updated version before I rebased, at least.

@ofborg ofborg bot added 10.rebuild-darwin: 1 and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Dec 24, 2024
@Jaculabilis
Copy link
Contributor Author

Filed #368968 to track the immich build failure. Is this PR blocked until that is fixed?

@Jaculabilis
Copy link
Contributor Author

immich build is fixed, branch is rebased to have the fix, nixos module test passes

@dotlambda dotlambda merged commit 64e0c30 into NixOS:master Jan 3, 2025
43 of 44 checks passed
@dotlambda
Copy link
Member

Sorry for my absence! Anyway, thanks for the contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants