Fix: translation strict null checks #472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdou6666
changed the title
abdou6666
force-pushed
the
fix/translation-strictNullChecks
branch
from
cb5442b to
5dcc1d8
Compare
marrouchi
requested changes
Dec 30, 2024
| @@ -77,7 +77,7 @@ export interface NumberSetting extends Setting { | |||
| type: SettingType.number; | |||
| value: number; | |||
| options: never; | |||
| config?: { | |||
| config: { | |||
There was a problem hiding this comment.
Suggested change
| config: { | |
| config?: { |
| @@ -83,7 +83,7 @@ export async function seedDatabase(app: INestApplicationContext) { | |||
| ...managerModels.map((model) => [model.id, managerRole.id]), | |||
| ] as [string, string][]; | |||
|
|
|||
| const permissionSeeds = roleModelsCombinations.reduce( | |||
| const permissionSeeds = roleModelsCombinations.reduce<PermissionCreateDto[]>( | |||
There was a problem hiding this comment.
Suggested change
| const permissionSeeds = roleModelsCombinations.reduce<PermissionCreateDto[]>( | |
| const permissionSeeds = roleModelsCombinations.reduce( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR make translation compliant with strictNullCheck
This PR should be merged after Settings PR #471
Fixes # (issue)
Type of change:
Please delete options that are not relevant.
Checklist: