Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: i18n strict null checks #473

Closed
wants to merge 5 commits into from
Closed

Fix: i18n strict null checks #473

wants to merge 5 commits into from

Conversation

abdou6666
Copy link
Member

Motivation

This PR makes i18n compliant with strictNullCheck true
This PR should be merged after Translation PR #472

Fixes

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@abdou6666 abdou6666 requested a review from marrouchi December 20, 2024 15:00
@abdou6666 abdou6666 mentioned this pull request Dec 20, 2024
Draft
9 tasks
@marrouchi marrouchi closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrouchi marrouchi Awaiting requested review from marrouchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdou6666 @marrouchi