Migrate custom nodes

[pythongosssss]

Adds custom node migration using manager snapshots

┆Issue is synchronized with this Notion page by Unito

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@types/[email protected]	None	0	10.4 kB	types
npm/[email protected]	filesystem	0	54.4 kB	raszi

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

[huchenlei]

Why can't us add anther custom_nodes path in the yaml file that links folder and reinstall their dependencies in the new python environment? Currently this restoration of snapshots seems a bit award as it requires the python env to be ready first.

[pythongosssss]

I don't think that is a very good method as:

1. at some point I want to remove my old manual installation and just have the desktop, where I would then need to manually reinstall them all
2. if I update custom nodes in one place, that will install the dependencies in one env, I then swap to the other installation and the custom nodes no longer work as I didn't update the nodes here, in this so new deps weren't installed

I think having the same source for custom nodes between two different environments, with different comfy versions, packages, etc will cause more trouble than it is worth

[huchenlei]

I don't think that is a very good method as:

1. at some point I want to remove my old manual installation and just have the desktop, where I would then need to manually reinstall them all
2. if I update custom nodes in one place, that will install the dependencies in one env, I then swap to the other installation and the custom nodes no longer work as I didn't update the nodes here, in this so new deps weren't installed

I think having the same source for custom nodes between two different environments, with different comfy versions, packages, etc will cause more trouble than it is worth

How about we directly copy the migration source's custom_nodes folder? This would help preserving data some custom nodes saved in their own folder.

[robinjhuang]

If we copy over the custom_nodes directory, we could use the reinstall command by passing in a list of custom nodes. @ltdrdata do you have opinion on what would be the best mechanism to "migrate" over custom nodes from another install?

[robinjhuang]

@pythongosssss FYI I synced with @ltdrdata and he mentioned he is planning to improve snapshot to also capture python package information. So I think we are good to go with the current approach.

[huchenlei]

Can you split the global toast change to a separate PR? I feel like having 2 levels of toast now can be confusing. For the custom node migration error reporting, we can fall back to use a electron system level message alert for now, and land the migration part first.