[Electron] Migrate custom nodes #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref: electron side PR: Comfy-Org/desktop#474 |
@pythongosssss Should we add an additional selection box here?
|
It's driven by electron side. Please make sure you have the electron side change patched first. |
huchenlei
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Can you split the global toast change to a separate PR? I feel like having 2 levels of toast now can be confusing. For the custom node migration error reporting, we can fall back to use a electron system level message alert for now, and land the migration part first.
pythongosssss
requested review from
Yorha4D,
KarryCharon,
DorotaLuna and
shinshin86
as code owners
huchenlei
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds custom node migration option and a generic toastr handler
┆Issue is synchronized with this Notion page by Unito