-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Docker Build/Compose and K8S #16737
base: dev
Are you sure you want to change the base?
Conversation
5a0fa91
to
f7d5d35
Compare
f7d5d35
to
919b2ee
Compare
@ShadowCrafter011 already updated his PR #16688 |
8618359
to
fae2f2f
Compare
.dockerignore
Outdated
.che__/ | ||
*.log | ||
*.git | ||
*.gitignoreivenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is going on with these ignore entries? "che", "gitignoreivenv", ... what?
Also shouldn't eg embeddings
, extensions
, etc. be ignored here? (ie anything that has a separate bind to forward it in)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.che__ is Eclipse env.
gitignoreivenv is a typo ... should be gitignore and .venv...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
README.md
Outdated
cd stable-diffusion-webui | ||
export TAG=v1.10.0 | ||
docker build -t stable-diffusion-webui:${TAG} -f docker/Dockerfile . | ||
docker run --gpus all -d -p 7860:7860 stable-diffusion-webui:${TAG} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(A) Minor, but formatting is a little weird here, double-spacing left in.
(B) Minor, but also the tag usage seems a bit unusual.
(C) the -v
for models isn't really optional, it should be included not a "if you happen to already have models". This line should have all the same contents as the compose does by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you. fixed
hmm, about (c) , after careful thought, you are right .even without pre-download model files in volume or in container, the webui.sh will still download image when containers up
There is already a docker image that have been maintained for over 1½ years. You can absolutely make a repo dedicated to build/compose of the webui and have it linked by the main repo so people can find it. But introducing Dockerfiles in to the main repo doesn't make much sense. |
we can discuss this topic in thread : #16688 |
Co-authored-by: Lukas <[email protected]> Signed-off-by: Peter Pan <[email protected]>
fae2f2f
to
50a6693
Compare
Description
Merging the PR from #16688
Add dockerfile for docker build
Added support for containerization with Docker. To run webui you need to have Docker installed, clone the repository and execute docker compose up in the root directory of the repository. The first startup installs all the dependencies and subsequent startups are much quicker. The webui is exposed at localhost:7860
Add support for k8s yaml
will add CI for automatic docker image build and pushing to dockerhub later
Screenshots/videos:
Checklist: