-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Docker. Container can easily be started with docker compose #16688
base: dev
Are you sure you want to change the base?
Added support for Docker. Container can easily be started with docker compose #16688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with Docker so my comments are only about the other changes
@@ -0,0 +1,19 @@ | |||
FROM python:3.10-bookworm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just python:3.10
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe another alternative is nvcr.io/nvidia/pytorch:24.12-py3 which torch and cuda embeded.
I'm testing this patch (0)
(1)
Guys, you can move on. |
Hi, @ShadowCrafter011 , I've created another PR #16737 to push the progress , since we do need a image now :-) which we together are co-author, can you please double check ? and @w-e-w , your comments are all addressed there.Thank you |
… they are persisted across restarts
@panpan0000 I've made some changes myself because using the webui I realised it needed volumes for configs, extensions and embeddings so that they are persisted. @w-e-w I've pushed a commit to address the changes you requested. |
source: ./embeddings | ||
target: /webui/embeddings | ||
- type: bind | ||
source: ./configs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there're already several yaml files under configs
folder, did you mean user can customize their own config to override the default ones ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I've gathered that's where the customizations made in the webui are persisted
There is already a docker image that have been maintained for over 1½ years. |
Hi, @silveroxides amazing, glad to see that . I found docker image's source code here , am I right ? https://github.com/universonic/docker-stable-diffusion-webui Per my understanding for open source community best practice : (1) I suggest that code(Dockerfile..etc) can be PR (merged) into this repo, as part of manifest of Putting those Dockerfile/K8S yaml in this code repo is a common practice. :
(2) we should provide automatic Github CI Action ,auto build new docker images tag when Anybody can cover that effort ? I think people in this thread are willing to. |
I understand your points but if you do check the state of this repo right now where the actual maintainer only appears once in a blue moon and w-e-w is being a real champ keeping stuff afloat otherwise, then you would probably understand that it isn't just as simple as a PR. We will have to see what happens going forward, but don't count on a swift merge of this or the other PR. |
anyone can create an PR for action / workflow, I believe it will work immediately after it's merged note: I currently only have right access to dev branch not main |
Description
Added support for containerization with Docker. To run webui you need to have Docker installed, clone the repository and execute
docker compose up
in the root directory of the repository. The first startup installs all the dependencies and subsequent startups are much quicker. The webui is exposed at localhost:7860Checklist: