Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak of grpc resolver #4490

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix memory leak of grpc resolver #4490

wants to merge 2 commits into from

Conversation

sauryniu
Copy link

Fix memory leak issue
There are two situations:

  1. The same grpc client is created repeatedly.
  2. Resolver.Close is called when grpc enters idle mode, and the resolver will be re-created the next time rpc is called.

@kevwan kevwan requested review from kevwan and MarkJoyMa December 13, 2024 16:15
@Nanosk07 Nanosk07 mentioned this pull request Dec 19, 2024
Open
@kevwan kevwan force-pushed the fix-discov branch 2 times, most recently from 3d5bca9 to d8c16f6 Compare December 22, 2024 16:57
@kevwan kevwan self-assigned this Dec 22, 2024
kevwan
kevwan reviewed Dec 28, 2024
View reviewed changes
core/discov/internal/registry.go
c, exists := r.getCluster(endpoints)
// if not exists, return.
if !exists {
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not exist, getCluster will create a cluster and save it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan left review comments

@MarkJoyMa MarkJoyMa Awaiting requested review from MarkJoyMa

At least 1 approving review is required to merge this pull request.

Assignees

@kevwan kevwan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sauryniu @kevwan