Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canalrcn #32990

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Canalrcn #32990

wants to merge 5 commits into from

Conversation

Ryan-Amirthan
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Add support for canalrcn.com videos. Canal RCN is a Colombian television channel. The extractor:

  • Extracts video metadata from JSON-LD data
  • Handles geo-restricted content (videos are only available in Colombia)
  • Delegates video playback to DailyMotion extractor through url_transparent

Example URLs:

@dirkf
Copy link
Contributor

dirkf commented Dec 12, 2024

Thanks for your work!

Some initial comments:

  • investigate the _search_json_ld(), or else _search_json(), methods
  • investigate the traverse_obj utility function
  • what happens if you aren't in CO and just carry on passing the video ID to DM?

You should find examples of using the mentioned methods and functions in newer extractors.

The existing ld+json parsing in the core code won't work for this site if what you need is the embedURL but it could/should be modified to separate finding and parsing as in yt-dlp, giving you access to the ld+json Pythonised JSON before it's made into an info-dict.

The test video at DM says that it's marked as private. Does that happen in CO, or does the site pass additional data (cookies, eg) to DM? Maybe that can be reproduced, if necessary, in the extractor for foreign telenovela fans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants