-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Zoom] Fix extractor #32828
base: master
Are you sure you want to change the base?
[Zoom] Fix extractor #32828
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
I have some work-in-progress to contribute. We should also ensure align the extractor with yt-dlp's as appropriate.
For now I've just made some initial suggestions.
I've taken the opportunity of your PR to make a wholesale update of the extractor, and I hope that's OK. It would be a big help if you were able to check that the revised code works well for you. |
Hey,
I'm on vacation with very limited access to a computer for the next
month.I can take a look when I'm back.
In a glance it looks great thanks for the rewrite.
…On Mon, 8 Jul 2024, 18:33 dirkf, ***@***.***> wrote:
I've taken the opportunity of your PR to make a wholesale update of the
extractor, and I hope that's OK. It would be a big help if you were able to
check that the revised code works well for you.
—
Reply to this email directly, view it on GitHub
<#32828 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXE4U32565KCWWJKKUASR3ZLJ2G7AVCNFSM6AAAAABKFAMLOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJTG43DQMJZHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
if url_type == 'share': | ||
webpage = self._get_real_webpage(url, base_url, video_id, 'share') | ||
meeting_id = self._get_page_data(webpage, video_id)['meetingId'] | ||
redirect_path = self._download_json( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if video doesn't exists like in the test https://us02web.zoom.us/rec/share/hkUk5Zxcga0nkyNGhVCRfzkA2gX_mzgS3LpTxEEWJz9Y_QpIQ4mZFOUx7KZRZDQA.9LGQBdqmDAYgiZ_8 result object will be None and accessing redirectUrl will throw a nasy exception.
maybe something like this?
if download_json['result'] is not None and 'redirectUrl' in download_json['result']:
redirect_path = download_json['result']['redirectUrl']
url = urljoin(base_url, redirect_path)
query['continueMode'] = 'true'
else:
if 'errorMessage' in download_json:
raise UnsupportedError(download_json['errorMessage'])
else:
raise UnsupportedError("No video found")
#32094
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This fixes the zoom extractor reported in #32094