-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vbox7,DASH] Fix and improve extraction with DASH manifests using range and base URL #32710
Conversation
* adapted from ytdl-org#30279 * thx former GH user kikuyan
* adapted from ytdl-org#30279 * thx former GH user kikuyan
Specs: * ISO/IEC 23009-1:2012 section 5.6 * RFC 3986 section 5.
* DASH extraction no longer fails with new range support * but always find combined formats if available * suppress ineffective XFF geo-bypass (causes time-outs) * adapted from ytdl-org#29680 * thx former GH user kikuyan
* based on PR ytdl-org#29680 * added hack to force invoking `transform_source` * fixes ytdl-org#26218
How can I manually install it and test it? |
Supposing that you have a supported Python installation, git clone the source repo; then go into the Otherwise you can manually replace the changed files in an installation from this repo's |
it works for downloading videos and m4a |
There are some extra features in the yt-dlp PR that can be added, but this can probably be merged as-is for now. |
Boilerplate (own/yt-dl/yt-dlp code, bug fix/improvement)
## Please follow the guide belowx
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This PR has three parts.
BaseURL
s.