[VidLii] Add 720p support (yt-dlp backport-ish) #30924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix a bug with the view count
mrpapersonic
changed the title
dirkf
requested changes
May 20, 2022
Co-authored-by: dirkf <[email protected]>
* tags: ['1', '2'] -> list * self._check_formats() used for checking HD url * self._search_regex -> self._html_search_regex Co-authored-by: dirkf <[email protected]>
We don't need to check if the 360p source is there
mrpapersonic
changed the title
|
@dirkf can this be re-reviewed? Looks like it got lost in the sea of current PRs. |
dirkf
reviewed
Jun 11, 2024
dirkf
requested changes
Jun 11, 2024
dirkf
approved these changes
Jun 11, 2024
github-actions bot
added a commit
to hellopony/youtube-dl
that referenced
this pull request
Jun 11, 2024
* https://github.com/ytdl-org/youtube-dl: [VidLii] Add 720p support (ytdl-org#30924) [ORF] Skip tests with limited availability [ORF] Re-factor and update`ORFFM4StoryIE` * fix getting media via DASH instead of inaccessible mp4 * also get in-page YT media [ORF] Support sound.orf.at, updating `ORFRadioIE` * maintain support for xx.orf.at/player/... URLs * add `ORFRadioCollectionIE` to support playlists in ORF Sound * back-port and re-work `ORFPodcastIE` from yt-dlp/yt-dlp#8486, thx Esokrates [ORF] Support on.orf.at, replacing `ORFTVthekIE` * add `ORFONIE`, back-porting yt-dlp PR yt-dlp/yt-dlp#9113 and friends: thx HobbyistDev, TuxCoder, seproDev * re-factor to support livestreams via new `ORFONliveIE` [test] Improve download test * skip reason can't be unicode in Py2 * remove duplicate assert...Equal functions [core] Re-factor with `_fill_common_fields()` as used in yt-dlp [core] Safer handling of nested playlist data [mixcloud] updated mixcloud API server address (ytdl-org#32557)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Adds HD support to VidLii.
This was originally done in #29291, but I deleted that fork a long time ago so I can't make any more edits to it.