[feedback welcome] fit chat_big/info/etc. in window #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dany-on-demand
commented
Jan 14, 2024
| // newlines | ||
|
|
||
| float font_fit_height(int max_width, float starting_height, char* text) { | ||
| float scalex = max_width / 800.0F; // not sure if I should consider this a hacky solution |
There was a problem hiding this comment.
scalex feels hacky... dunno
dany-on-demand
commented
Jan 14, 2024
| int i = 0; | ||
| while(chat_popup_line != NULL) { | ||
| char* next_line = strchr(chat_popup_line, '\n'); | ||
| char chat_popup_temp[256]; |
There was a problem hiding this comment.
is there a better way?
dany-on-demand
commented
Jan 14, 2024
| strcpy(chat_popup_temp, chat_popup_line); | ||
| chat_popup_line = NULL; | ||
| } | ||
| float text_pixel_width = font_length(chat_popup_height, chat_popup_temp); |
There was a problem hiding this comment.
this value could be 'cached' too
dany-on-demand
force-pushed
the
fix-big-chat
branch
from
aa1643e to
1189a43
Compare
dany-on-demand
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scalex situation in font_fit_height works but feels hacky