Fix weapon reload not stopping when player switches tools #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cancels weapon reloading if the player switches tools, this is the behavior that can be observed in the VOXLAP server.exe and in SpadesX. Closes xtreme8000#174
|
Should be noted that this has been worked around by server to send finish reload packet with the original ammo count to the client once we cancel. This prevents any of the funky business. Server = SpadesX. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the original client, the weapon reload gets cancelled if you switch of tool while reloading your weapon.
The bundled in server and SpadesX follow this behavior by sending a reload cancel packet, however, BetterSpades proceeds with the reloading anyway.
This PR changes it to be more in line with VOXLAP.