-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wingui port from @Bill-Gray, backported to the mainline #86
base: master
Are you sure you want to change the base?
Conversation
Subsequent commits will document what I changed, and why, to port this code to the mainline PDCurses.
Adapted from the one in wincon.
Just so we're clear: This has no extended color, no 64 bit chtype; just the wingui port. |
Hmmm... so this is basically WinGUI modified so that it can be dropped in next to the rest of the @wmcbrine fork and compile and work with it, without requiring modification of (for example) I admit to feeling somewhat conflicted about this. Obviously, it involves "dumbing down" my version rather heavily : no Unicode past the BMP, limited colors and color pairs, no fullwidth or combining characters, limited range of keystrokes, several attributes missing, etc., etc. Anyone using an Asian language is, to some degree, left out. But I made the pull request involved four years ago, and it hasn't gone anywhere. I think we can safely assume that's a "no". Given that reality, yours is a decent solution for anyone who is, for some reason, forced into the limitations of mainline PDCurses but who would still like to use WinGUI, and I hope it gets pulled into mainline PDCurses. I will close my original pull request, and we'll see what happens with this one. |
I'd like to see the greater support for Unicode and all the rest. But these features are probably best broken out into separate pull requests. |
@wmcbrine Please drop a note if "including a minimized WinGUI port" is something relevant here and may be redone/updated from current PDCursesMod or if it would be done on your side (if you find the time to include it) in any case - then closing this PR may be the reasonable way to go. Thanks. |
Here is @Bill-Gray's wingui port, plucked out of his fork and edited to compile and run with the mainline PDCurses.
CMakeLists.txt is broken and I don't know enough about CMake to fix it. Makefile.bcc might be broken; I don't have a 32 bit version of Windows or a Borland compiler that might be compatible with Windows 8. The other Makefiles are all tested with and without -DWIDE=Y.