Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix round(5) crash, check type error #5967

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

leaout
Copy link
Contributor

@leaout leaout commented Nov 1, 2024

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

return round(5) crash

How do you solve it?

add type check

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@CLAassistant
Copy link

CLAassistant commented Nov 1, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@Salieri-004 Salieri-004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@codesigner codesigner enabled auto-merge (squash) November 7, 2024 08:36
@Salieri-004
Copy link
Contributor

@leaout Please sign Contributor License Agreement

@leaout
Copy link
Contributor Author

leaout commented Nov 7, 2024

@leaout Please sign Contributor License Agreement

image
License is ok

@Salieri-004 Salieri-004 added ready-for-testing PR: ready for the CI test ready for review and removed ready-for-testing PR: ready for the CI test ready for review labels Nov 7, 2024
@Salieri-004
Copy link
Contributor

@leaout Could you check this page?
image

@leaout
Copy link
Contributor Author

leaout commented Nov 8, 2024

@leaout Could you check this page? image

User name And email address had error, first commit message was not to be modified,what should I do?

@Salieri-004
Copy link
Contributor

@leaout Could you check this page? image

User name And email address had error, first commit message was not to be modified,what should I do?

Could you roll back and recommit it?

auto-merge was automatically disabled November 8, 2024 06:50

Head branch was pushed to by a user without write access

@codesigner codesigner merged commit 6c59b79 into vesoft-inc:master Nov 11, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants