Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IndexScan with label containing parameters #5944

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

Xscaperrr
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:#5939

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@czpmango
Copy link
Contributor

@Xscaperrr
Copy link
Contributor Author

Please fix https://github.com/vesoft-inc/nebula/pull/5938/files#r1772790763

Already fixed it .The corresponding test has been enabled.

Copy link
Contributor

@czpmango czpmango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xscaperrr
Copy link
Contributor Author

@Salieri-004 Please help me with this issue,thanks

@Salieri-004
Copy link
Contributor

@Salieri-004 Please help me with this issue,thanks

Sorry to keep you waiting. LGTM.

@codesigner codesigner merged commit 6e0f646 into vesoft-inc:master Nov 18, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants