chore: fix session pool del before lock #367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wey-gu
commented
Oct 22, 2024
•
wey-gu
commented
tests/test_session_pool.py::test_session_pool_multi_thread
tests/test_session_pool.py::TestSessionPoolBasic::test_pool_init
/home/runner/work/nebula-python/nebula-python/.venv/lib/python3.12/site-packages/_pytest/unraisableexception.py:78: PytestUnraisableExceptionWarning: Exception ignored in: <function SessionPool.__del__ at 0x7f7fff215760>
Traceback (most recent call last):
File "/home/runner/work/nebula-python/nebula-python/nebula3/gclient/net/SessionPool.py", line 73, in __del__
self.close()
File "/home/runner/work/nebula-python/nebula-python/nebula3/gclient/net/SessionPool.py", line 329, in close
with self._lock:
^^^^^^^^^^
AttributeError: 'SessionPool' object has no attribute '_lock'
|
0919c79 fixed the ci on py37, this should be fine as we have test coverage running over 3.7 w/o PDM already, plus PDM now is 3.8+ actually. |
wey-gu
commented
Oct 22, 2024
| @@ -52,7 +52,7 @@ jobs: | |||
| strategy: | |||
| max-parallel: 2 | |||
| matrix: | |||
| python-version: [3.7, 3.8, 3.9, '3.10', 3.11] | |||
| python-version: [3.8, 3.9, '3.10', 3.11] | |||
There was a problem hiding this comment.
this should be fine as we have test coverage running over 3.7 w/o PDM already, plus PDM now is 3.8+ actually.
HarrisChu
reviewed
Oct 22, 2024
| @@ -70,7 +70,8 @@ def __init__(self, username, password, space_name, addresses): | |||
| self._close = False | |||
|
|
|||
| def __del__(self): | |||
| self.close() | |||
| if hasattr(self, '_lock'): | |||
| self.close() | |||
There was a problem hiding this comment.
the root cause is when init the pool if the address is invalid, would raise exception
so the object has no _lock property.
prefer move the exception at the end of init function
and the every object has _lock property.
There was a problem hiding this comment.
the current change it's also ok for me.
there's the same issue with meta client, please fix it in the same way
Nicole00
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.