Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(isFolderEmpty): store valid files in a set #74324

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

twlite
Copy link

@twlite twlite commented Dec 27, 2024

This pull request includes changes to the is-folder-empty.ts file to improve performance and code readability. The most important changes include converting the validFiles array to a Set and updating the corresponding method to use the Set's has method.

Improvements to performance and readability:

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Dec 27, 2024
@ijjk
Copy link
Member

ijjk commented Dec 27, 2024

Allow CI Workflow Run

  • approve CI run for commit: 54fbbb7

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants