perf(isFolderEmpty): store valid files in a set #74324
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
is-folder-empty.ts
file to improve performance and code readability. The most important changes include converting thevalidFiles
array to aSet
and updating the corresponding method to use theSet
'shas
method.Improvements to performance and readability:
packages/create-next-app/helpers/is-folder-empty.ts
: ConvertedvalidFiles
from an array to aSet
for improved lookup performance. [1] [2]packages/create-next-app/helpers/is-folder-empty.ts
: Updated theisFolderEmpty
function to use theSet
'shas
method instead ofincludes
.