Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types): cleanup types / useless expression #74270

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

nnnnoel
Copy link

@nnnnoel nnnnoel commented Dec 24, 2024

For Contributors

Improving Documentation

For Maintainers

  • Minimal description (aim for explaining to someone not on the team to understand the PR)
  • When linking to a Slack thread, you might want to share details of the conclusion
  • Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
  • Add review comments if necessary to explain to the reviewer the logic behind a change

What?

I refactored some any types in build file, because it's too hard to know what original typed in huge project.
and added typedEntries lib for better type inference than Object.entries. When if you keep key/value pair type as constantly, i think it's useful.

Why?

How?

@ijjk
Copy link
Member

ijjk commented Dec 24, 2024

Allow CI Workflow Run

  • approve CI run for commit: 7eca19a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@nnnnoel nnnnoel force-pushed the refactor/cleanup-types branch from b5eb06e to 7eca19a Compare December 27, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants