Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port ErrorPagination #74097

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Port ErrorPagination #74097

merged 3 commits into from
Dec 20, 2024

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Dec 18, 2024 •
edited
Loading

Ported ErrorPagination and replaced in the Errors component.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 18, 2024
This was referenced Dec 18, 2024
Merged
Merged
@devjiwonchoi Graphite App
Copy link
Member Author

devjiwonchoi commented Dec 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 18, 2024
Merged
Merged
Merged
@ijjk
Copy link
Member

ijjk commented Dec 18, 2024 •
edited
Loading

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js 12-19-port_errorpagination Change
buildDuration 21.4s 19s N/A
buildDurationCached 17.9s 15.6s N/A
nodeModulesSize 416 MB 416 MB N/A
nextStartRea..uration (ms) 527ms 520ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 12-19-port_errorpagination Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 52.8 kB 52.8 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 12-19-port_errorpagination Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js 12-19-port_errorpagination Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js 12-19-port_errorpagination Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js 12-19-port_errorpagination Change
index.html gzip 522 B 524 B N/A
link.html gzip 537 B 537 B ✓
withRouter.html gzip 518 B 520 B N/A
Overall change 537 B 537 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 12-19-port_errorpagination Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js 12-19-port_errorpagination Change
middleware-b..fest.js gzip 670 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js 12-19-port_errorpagination Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 359 kB 359 kB N/A
app-page-exp..prod.js gzip 129 kB 129 kB ✓
app-page-tur..prod.js gzip 142 kB 142 kB ✓
app-page-tur..prod.js gzip 137 kB 137 kB ✓
app-page.run...dev.js gzip 348 kB 348 kB N/A
app-page.run..prod.js gzip 125 kB 125 kB ✓
app-route-ex...dev.js gzip 37.5 kB 37.5 kB ✓
app-route-ex..prod.js gzip 25.5 kB 25.5 kB ✓
app-route-tu..prod.js gzip 25.5 kB 25.5 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 39.2 kB 39.2 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 1.73 MB 1.73 MB ✓
build cache
vercel/next.js canary vercel/next.js 12-19-port_errorpagination Change
0.pack gzip 2.08 MB 2.08 MB N/A
index.pack gzip 73.7 kB 73.7 kB N/A
Overall change 0 B 0 B ✓
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page.runtime.dev.js 
failed to diff
Commit: 3ea6565

@devjiwonchoi devjiwonchoi marked this pull request as ready for review December 18, 2024 21:40
@devjiwonchoi devjiwonchoi requested review from ijjk and gaojude December 18, 2024 21:40
@devjiwonchoi devjiwonchoi force-pushed the 12-19-move_errorindicator_to_separate_file branch from df1a0c5 to 71c07e7 Compare December 18, 2024 21:44
@devjiwonchoi devjiwonchoi force-pushed the 12-19-port_errorpagination branch from 1d60679 to d888d8c Compare December 18, 2024 21:45
@devjiwonchoi devjiwonchoi force-pushed the 12-19-move_errorindicator_to_separate_file branch from 71c07e7 to f694427 Compare December 18, 2024 23:05
@devjiwonchoi devjiwonchoi force-pushed the 12-19-port_errorpagination branch from d888d8c to 19551a2 Compare December 18, 2024 23:05
@devjiwonchoi devjiwonchoi mentioned this pull request Dec 18, 2024
Merged
@devjiwonchoi devjiwonchoi force-pushed the 12-19-move_errorindicator_to_separate_file branch 2 times, most recently from 8eb1126 to f1b0bd2 Compare December 19, 2024 09:03
@devjiwonchoi devjiwonchoi force-pushed the 12-19-port_errorpagination branch from 19551a2 to e54b9c3 Compare December 19, 2024 09:03
@devjiwonchoi devjiwonchoi force-pushed the 12-19-move_errorindicator_to_separate_file branch from f1b0bd2 to bb4c806 Compare December 19, 2024 16:09
@devjiwonchoi devjiwonchoi force-pushed the 12-19-port_errorpagination branch from e54b9c3 to 7b685a6 Compare December 19, 2024 16:10
@devjiwonchoi devjiwonchoi mentioned this pull request Dec 19, 2024
Closed
@devjiwonchoi Graphite App
Copy link
Member Author

devjiwonchoi commented Dec 19, 2024 •
edited
Loading

Merge activity

  • Dec 19, 3:48 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 19, 3:51 PM EST: Graphite rebased this pull request as part of a merge.
  • Dec 19, 4:16 PM EST: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'thank you, next', 'test dev (5/6) / build', 'test ppr dev (3/6) / build').
  • Dec 20, 9:12 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 20, 9:12 AM EST: A user merged this pull request with Graphite.

@devjiwonchoi devjiwonchoi changed the base branch from 12-19-move_errorindicator_to_separate_file to graphite-base/74097 December 19, 2024 20:48
@devjiwonchoi devjiwonchoi changed the base branch from graphite-base/74097 to canary December 19, 2024 20:49
@devjiwonchoi devjiwonchoi force-pushed the 12-19-port_errorpagination branch from 7b685a6 to a9a4d6b Compare December 19, 2024 20:50
@ijjk
Copy link
Member

ijjk commented Dec 19, 2024 •
edited
Loading

Tests Passed

@devjiwonchoi devjiwonchoi force-pushed the 12-19-port_errorpagination branch from a9a4d6b to 321b4bc Compare December 20, 2024 03:14
@devjiwonchoi devjiwonchoi requested a review from gaojude December 20, 2024 06:14
@devjiwonchoi devjiwonchoi merged commit b40e1a2 into canary Dec 20, 2024
141 checks passed
@devjiwonchoi devjiwonchoi deleted the 12-19-port_errorpagination branch December 20, 2024 14:12
@devjiwonchoi devjiwonchoi mentioned this pull request Dec 25, 2024
Merged
devjiwonchoi added a commit that referenced this pull request Dec 25, 2024
@devjiwonchoi
[DevOverlay] fix: restore pagination style (#74296)
26f6133 
### Why?

This PR restores the pagination style, which was accidentally omitted at #74097.

#### Before

![Screenshot 2024-12-25 at 8.37.33 PM.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/dQEaKpg78raP6UllhQTZ/4c164615-3f55-4423-9049-7e1827b454be.png)

#### After

![Screenshot 2024-12-25 at 8.37.07 PM.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/dQEaKpg78raP6UllhQTZ/c3693982-7592-40c5-bf46-bf9c0379af22.png)
@github-actions github-actions bot added the locked label Jan 4, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk Awaiting requested review from ijjk

@huozhi huozhi Awaiting requested review from huozhi

@eps1lon eps1lon Awaiting requested review from eps1lon

@gaojude gaojude Awaiting requested review from gaojude

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devjiwonchoi @ijjk @gaojude