handle trailing slash on endpoint

based on nodevault#176 fixes nodevault#175 Co-authored-by: Jason Nguyen <[email protected]> Co-authored-by: Bret Hubbard <[email protected]
vaultaire · Apr 24, 2022 · 079bde1 · 079bde1
1 parent 9b2432c
commit 079bde1
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/src/index.js b/src/index.js
@@ -89,6 +89,8 @@ function NodeVault(config = {}) {
   client.noCustomHTTPVerbs = config.noCustomHTTPVerbs || false;
   client.namespace = config.namespace || process.env.VAULT_NAMESPACE;
 
+  client.endpoint = client.endpoint.replace(/\/$/, '');
+
   const requestSchema = {
     type: 'object',
     properties: {

diff --git a/test/unit.js b/test/unit.js
@@ -80,6 +80,31 @@ describe('vaultaire', () => {
     });
   });
 
+  describe('client initialization', () => {
+    it('should not trim endpoint if no trailing slash', () => {
+      const defaultsStub = sinon.stub();
+      const vaultConfig = {
+        endpoint: 'http://localhost:8200',
+        'request-promise': {
+          defaults: defaultsStub,
+        },
+      };
+      const vault = NodeVault(vaultConfig);
+      vault.endpoint.should.equal('http://localhost:8200');
+    });
+
+    it('should trim endpoint if trailing slash', () => {
+      const defaultsStub = sinon.stub();
+      const vaultConfig = {
+        endpoint: 'http://localhost:8200/',
+        'request-promise': {
+          defaults: defaultsStub,
+        },
+      };
+      const vault = NodeVault(vaultConfig);
+      vault.endpoint.should.equal('http://localhost:8200');
+    });
+  });
 
   describe('client', () => {
     let request = null;