effects for LMMs #160
Merged
effects for LMMs #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| function StatsModels.modelmatrix(model::UnfoldLinearMixedModel, bool) | ||
| @assert bool == false "time continuous model matrix is not implemented for a `UnfoldLinearMixedModel`" | ||
| return designmatrix(model).Xs[1] | ||
| end |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| end | |
| end |
| times(model::Union{<:UnfoldLinearMixedModel,<:UnfoldLinearModel}) = times(design(model)) | ||
| times( | ||
| d::Dict{<:Union{Any,<:AbstractString,Symbol},<:Tuple{<:AbstractTerm,<:AbstractVector}}, | ||
| ) = first(values(d))[2]#[k[2] for k in values(d)] # probably going for steprange would be better | ||
|
|
||
|
|
||
| function gen_timeev(timesVec,nRows) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function gen_timeev(timesVec,nRows) | |
| function gen_timeev(timesVec, nRows) |
| evts, | ||
| data, | ||
| ) | ||
| @test_broken eff = effects(Dict(:condition => ["car", "face"]), m) | ||
| end |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| end | |
| end |
I think it's about this broken test I wrote in the tests for the io functions. It's broken because effects was not defined for UnfoldLinearMixedModel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this finally adresses #113
What I havent implemented is for ContinuousTime LMMs, but that should be easy, I did run out of steam though, so at a later point
@jschepers what is the mention in #114 on a broken test?