-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Fixed the Gemfile to work on Windows (+ other general changes) #1113
base: master
Are you sure you want to change the base?
[fix] Fixed the Gemfile to work on Windows (+ other general changes) #1113
Conversation
@JustinBack PLEASE HELP ME NOW |
Thats correct, Jira is for internal ToS;DR use only. However I've created an issue for it https://tosdr.atlassian.net/browse/EDIT-95 Will test the PR and if all goes well, merge it :-) |
Added information for Microsoft Windows
OK now? |
Justin, is it okay to merge now? |
We are still discussing internally things related to the dependencies. |
I've had talks with @madoleary and we noticed that adding those dependencies breaks our Gitpod Integration, the CI seems to fail and running it in a linux environment fails. Especially the dependencies are a huge problem in this PR as we cannot really test the breaking change from pg 0.21 to 1.4, as well as adding a lot of dependencies on all OS just to run the dev environment on windows + gem 'sys-proctable'
+ gem 'fast_stack'
+ gem 'tzinfo-data' We feel like making certain local modifications when trying to spin up an open source project in dev env is just kind of the way it is when working on open source stuff. You are free to use Gitpod (as its free for a generous amount of time) and spins up a cloud-based ready-to-code instance of Phoenix Though we like your changes to the quickstart and would like to merge those! If you'd like to, you can contribute a Once we've migrated to Ruby 3, the compability might be better with Windows, so don't take this as a "we would never support Windows" :-) |
Okay, I will try to fix those |
As per PR tosdr#1113
Removing unnecessary changes
OK now? |
Okay? |
Recommended by @madoleary on tosdr#1113
Feature: EDIT-12 Added XXX
Thanks !
Version 1.2.13
This version contains fixes for the Gemfile, in order the make Phoenix work on Microsoft Windows.