feat: Compose multiplatform strings import & export #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anty0
changed the title
Anty0
force-pushed
the
jirikuchynka/compose-multiplatform
branch
from
6aa07de to
8812d76
Compare
Anty0
force-pushed
the
jirikuchynka/compose-multiplatform
branch
3 times, most recently
from
abe6d79 to
b149de6
Compare
JanCizmar
approved these changes
Dec 20, 2024
| @@ -59,8 +59,8 @@ class AndroidXmlFileExporterTest { | |||
| |<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2"> | |||
| | <string name="i_am_array_english">This is english!</string> | |||
| | <plurals name="plural_with_placeholders"> | |||
| | <item quantity="one">%s dog</item> | |||
| | <item quantity="other">%s dogs</item> | |||
| | <item quantity="one">%1${'$'}s dog</item> | |||
There was a problem hiding this comment.
I believe it is. One of the changes this PR makes is that both Android and Compose Multiplatform will always use numbered placeholders from now on (also mentioned in the original issue: #2397 (comment)). Tests were adjusted to accompany this change. Is this okay, or did I miss something?
Anty0
force-pushed
the
jirikuchynka/compose-multiplatform
branch
from
de2f716 to
487f8bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2397