Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): cluster metrics duplicate #9416

Merged

Conversation

darkskygit
Copy link
Member

No description provided.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 51.53%. Comparing base (cec4a4b) to head (e630290).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...kages/backend/server/src/plugins/gcloud/metrics.ts 33.33% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9416      +/-   ##
==========================================
- Coverage   51.76%   51.53%   -0.23%     
==========================================
  Files        2148     2148              
  Lines       97097    97111      +14     
  Branches    16298    16261      -37     
==========================================
- Hits        50259    50051     -208     
- Misses      45450    45675     +225     
+ Partials     1388     1385       -3     
Flag Coverage Δ
server-test 78.13% <33.33%> (-0.68%) ⬇️
unittest 30.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Dec 30, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the darksky/fix-cluster-timestamp-metrics-duplicate branch from 0e6b286 to e630290 Compare December 30, 2024 02:25
@graphite-app graphite-app bot merged commit e630290 into canary Dec 30, 2024
61 checks passed
@graphite-app graphite-app bot deleted the darksky/fix-cluster-timestamp-metrics-duplicate branch December 30, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants