-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jq: update page #14841
Merged
Merged
jq: update page #14841
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
beee855
resolve conflict
vanvuvuong 3a088cc
adding ending colon
vanvuvuong f1b8cd7
update example description
vanvuvuong 5ba0ff5
update based on comment
vanvuvuong 9218ff1
rebase
6b7a3b7
update findmnt example description
vanvuvuong 81739ca
add more sha256sum example
357208a
udpate jq page
vanvuvuong 210b295
add more jq example & remove duplicated one
vanvuvuong 69bf1e2
remove another edit commit
vanvuvuong 295622c
Merge branch 'main' into jq
vanvuvuong f6e62cc
Update jq.md
sebastiaanspeck c8e6766
remove see more
vanvuvuong e3b5480
Merge branch 'main' into jq
vanvuvuong 6df614f
Merge branch 'main' into jq
vanvuvuong 5e1d635
Merge branch 'main' into jq
vanvuvuong 00b5593
Merge branch 'main' into jq
vanvuvuong 82db2b2
update based on comments
vanvuvuong f61ac3d
Merge branch 'main' into jq
vanvuvuong 2e201f9
update example based on comment
vanvuvuong d40f047
Merge branch 'main' into jq
vanvuvuong 44cea44
update example based on comment
vanvuvuong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we shouldn't have a redundant example just to show the file input, although it is useful. I'll see what the other reviewers say. Related #13668
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one or the first example needs to delete, it is basically the same, just different way of stdin controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep the second example. The cat-page should show us that this is possible. Not in a non-related page. If someone never views jq, they will never know. It is more likely they will view cat, and then see the
|
example.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel strongly either way. @vanvuvuong maybe keep the second example and we can get it merged and fix it later if it needs to be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated