Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various ui tweaks #59

Merged
merged 7 commits into from
Jan 9, 2024
Merged

various ui tweaks #59

merged 7 commits into from
Jan 9, 2024

Conversation

bragefuglseth
Copy link

@bragefuglseth bragefuglseth commented Jan 6, 2024

Various changes to the UI to make it more elegant and robust. There are too many small ones to list here, so read through all of the changed code to see if there's anything you want to be different, but the most significant tweaks are:

  • Making the image extend all the way to the top of the window in desktop mode
  • Changing the "Dither It!" label into "Save Image" (I know, less fun, but it makes a lot more sense workflow-wise, as the dithered image is already visible)
  • Moving the mentioned button into a bottom toolbar to avoid clutter
  • Moving more properties into the breakpoint instead of setting them with bindings, to make things more tidy and concentrate adaptive properties in one place

Skjermbilde fra 2024-01-06 22-08-06

Please let me know if you want anything changed!

@tfuxu
Copy link
Owner

tfuxu commented Jan 7, 2024

Looks amazing!

Some small nitpicks:

  • explanation popovers have inconsistent padding,
  • F10 shortcut works even if sidebar is hidden,
  • Custom headerbar CSS only works for close button,
  • minor formatting inconsistencies

Nothing that I can't fix myself, after that both PRs should be ready for merge.

@tfuxu
Copy link
Owner

tfuxu commented Jan 7, 2024

Also, is visible-child-name: "desktop"; in line 77 needed? Nvm, it can be useful to indicate default headerbar state

@bragefuglseth
Copy link
Author

bragefuglseth commented Jan 7, 2024

The new changes look good to me.

@tfuxu tfuxu merged commit 2afe4dd into tfuxu:hig-changes Jan 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants