Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ExecutionMutableStateSuite #7026

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ExecutionMutableStateSuite #7026

wants to merge 1 commit into from

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Dec 20, 2024

What changed?

  • Fix how branchToken is created and used in ExecutionMutableStateSuite
  • More assertions
  • Some variable rename

Why?

  • The test was using the same branch token for multiple different runs and worked in a weird way (new record happens to overwrite old record in DB).

How did you test it?

Potential risks

Documentation

Is hotfix candidate?

@yycptt yycptt requested a review from a team as a code owner December 20, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prathyushpv prathyushpv prathyushpv approved these changes

@alfred-landrum alfred-landrum Awaiting requested review from alfred-landrum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @prathyushpv