Create test-runner command for rerunning tests #6842
Merged
+605
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
commented
Nov 19, 2024
bergundy
commented
Nov 19, 2024
bergundy
commented
Nov 19, 2024
| @@ -405,13 +402,13 @@ prepare-coverage-test: $(GOTESTSUM) $(TEST_OUTPUT_ROOT) | |||
|
|
|||
| unit-test-coverage: prepare-coverage-test | |||
| @printf $(COLOR) "Run unit tests with coverage..." | |||
| $(GOTESTSUM) --rerun-fails=$(FAILED_TEST_RETRIES) --rerun-fails-max-failures=10 --junitfile $(NEW_REPORT) --packages $(UNIT_TEST_DIRS) -- \ | |||
| go run ./cmd/tools/test-runner $(GOTESTSUM) -retries $(FAILED_TEST_RETRIES) --junitfile $(NEW_REPORT) --packages $(UNIT_TEST_DIRS) -- \ | |||
There was a problem hiding this comment.
I think there's a way to pre-build this in our CI setup. I can look into that if anyone thinks using go run would be an issue.
There was a problem hiding this comment.
Anything you build in pre-build-functional-test-coverage will go into the per-run cache. That won't cover the final binary (I think) but the object files. I wouldn't worry about it, though, the compile+link time should be negligible.
ychebotarev
reviewed
Nov 19, 2024
bergundy
force-pushed
the
test-runner
branch
from
ce17fd1 to
04fca19
Compare
ychebotarev
reviewed
Nov 19, 2024
ychebotarev
reviewed
Nov 19, 2024
ychebotarev
reviewed
Nov 19, 2024
ychebotarev
reviewed
Nov 19, 2024
ychebotarev
approved these changes
Nov 19, 2024
alexshtin
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a test-runner command for rerunning tests and modified the Makefile to use the new command.
Why?
gotestsum is supposed to do this but it is buggy: gotestyourself/gotestsum#423.
If this runner works well we can stop using gotestsum if we choose but I would probably recommend using it since it claims to do exactly what we need.
An alternative would be to either generate test reports using JSON output or using https://github.com/jstemmer/go-junit-report to create junit XML reports.
How did you test it?