Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang.org/x/net to 0.33.0 #2451

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vdemeester
Copy link
Member

Changes

See GHSA-w32m-9786-jp63

cc @tektoncd/cli-maintainers

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Update golang.org/x/net dependency to 0.33.0 to fix CVE-2024-45338

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 20, 2024
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 20, 2024
@vdemeester vdemeester force-pushed the bump-golang-net branch 2 times, most recently from 73a7a2d to 9969788 Compare December 20, 2024 13:33
@chmouel
Copy link
Member

chmouel commented Dec 20, 2024

/retest
/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2025
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
@tekton-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2025
@tekton-robot
Copy link
Contributor

@vdemeester: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-cli-build-cross-tests ea5f900 link true /test pull-tekton-cli-build-cross-tests
pull-tekton-cli-unit-tests ea5f900 link true /test pull-tekton-cli-unit-tests
pull-tekton-cli-build-tests ea5f900 link true /test pull-tekton-cli-build-tests
pull-tekton-cli-integration-tests ea5f900 link true /test pull-tekton-cli-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants