-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add long flag --display-name to display the log of pipelinerun #2450
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @icloudnote. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I am afraid this may be breaking people that rely on that output... |
maybe a flag like --long to display more info and have the displayname into it? |
good idea |
05046d5
to
de8e888
Compare
/ok-to-test |
@icloudnote: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3bd40a3
to
de8e888
Compare
I have add new flag |
/ok-to-test |
what do you think about --long instead as we can add more verbose output in the future and not necessary have to add a flag for every kind of detailed output |
For more detailed output, I personally feel that it may not be a good idea to put it in the prefix. After all, prefixes are often used to quickly locate problems and query logs of related steps. The format of The log format of using the |
Changes
Add a new long flag
--display-name
to show pipelinerun logs, when--display-name=true
, show logs with task display name.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make check
make generated
See the contribution guide
for more details.
Release Notes