Power proposals from Dataset API fixes #290 #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonwilliams
requested review from
smorimoto and
codehag
and removed request for
smorimoto
smorimoto
reviewed
Jul 29, 2022
smorimoto
reviewed
Jul 29, 2022
smorimoto
approved these changes
Jul 29, 2022
- Add back editorConfig, its useful when commiting from Windows to make sure LF is set. - eleventyApi uses a .cache file to store the response ignore this. Needed from dataset.. - Presented? - Presented Date - Has specification? - examples - ECMA-262 doesn't need adding to the tags if tests is already available as a property
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could in theory add all the proposals to the website now but ill leave that out of scope for this.
Issue raised with dataset for missing data: tc39/dataset#15
fixes #290