Migrate to upstream workspace/textDocumentContent
#1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be required for importing vscode-languageclient/node now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling PR to
getReferenceDocumentrequest totextDocumentContentsourcekit-lsp#1639The
workspace/textDocumentContentAPI will be upstreamed as part of the upcoming version 3.18 of LSP, thus we no longer need a non-standardworkspace/getReferenceDocumentimplementation. Some notes on the implementation:vscode-languageclientversion 10, which is currently in beta. The migration requires using a different module resolution and updating some imports.LanguageClientinstanceSince we may want to hold off with this until LSP 3.18 is finalized and the sourcekit-lsp PR is merged, I'm marking this PR as a draft for now. It already works, however, and can be used for testing.