Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version: set the version back to 6.1.0 #8173

Open
wants to merge 1 commit into
base: release/6.1
Choose a base branch
from
Open

version: set the version back to 6.1.0 #8173

wants to merge 1 commit into from

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented Dec 13, 2024 •
edited
Loading

Update the branch to accurately reflect the version.

Motivation:

Need to accurately display the version

Modifications:

Reverted #8135

Result:

N/A

@bkhouri bkhouri mentioned this pull request Dec 13, 2024
Merged
@shahmishal
Copy link
Member

I would recommend doing git revert fe8501667c18ddc077aebbb9e9da8ddf0556be89 so it's easier to track the reverts.

@bkhouri bkhouri force-pushed the t/release6.1/set_version_back_to_6.1 branch from 8313136 to 38e3d65 Compare December 13, 2024 19:44
@bkhouri
Copy link
Contributor Author

bkhouri commented Dec 13, 2024

I would recommend doing git revert fe8501667c18ddc077aebbb9e9da8ddf0556be89 so it's easier to track the reverts.

Good call. done

@bkhouri
Copy link
Contributor Author

bkhouri commented Dec 13, 2024

@swift-ci please test

@shahmishal
Copy link
Member

@swift-ci please test Windows

@bkhouri bkhouri marked this pull request as ready for review December 13, 2024 21:22
@bkhouri
Copy link
Contributor Author

bkhouri commented Dec 19, 2024

@swift-ci Please test nightly self hosted

@bkhouri
Copy link
Contributor Author

bkhouri commented Dec 19, 2024

@swift-ci test

1 similar comment
@bkhouri
Copy link
Contributor Author

bkhouri commented Dec 19, 2024

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal shahmishal approved these changes

@jakepetroules jakepetroules jakepetroules approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

@francescomikulis francescomikulis Awaiting requested review from francescomikulis francescomikulis is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkhouri @shahmishal @jakepetroules