Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the Contributor Experience Workgroup code-own the respective page #802

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Have the Contributor Experience Workgroup code-own the respective page #802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,19 @@
###

# The following lines are used by GitHub to automatically recommend reviewers.
#
# Lines starting with '#' are comments.
# Each line is a case-sensitive file pattern followed by one or more owners.
# Order is important — the last matching pattern has the most precedence.
# More information: https://docs.github.com/en/articles/about-code-owners
#
# Please mirror the repository's file hierarchy in case-sensitive lexicographic
# order.
Comment on lines +30 to +37
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I borrowed this header from swift.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I looked at this PR through GitHub's web interface, it's complaining there's an error in the file:

Unknown owner on line 43: make sure the team @swiftlang/contributor-experience exists, is publicly visible, and has write access to the repository

Copy link
Contributor Author

@AnthonyLatsis AnthonyLatsis Sep 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Makes sense though — an entity needs write access to own something.


* @0xTim @alexandersandberg @daveverwer @dempseyatgithub @parispittman @kaishin @shahmishal @timsneath @federicobucchi

/_posts/* @timsneath @tkremenek @shahmishal

/contributor-experience-workgroup/ @swiftlang/contributor-experience

/gsoc*/ @ktoso